Add error for regex with no named groups #12
Merged
+34
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #12 +/- ##
==========================================
+ Coverage 75.93% 76.02% +0.09%
==========================================
Files 60 60
Lines 3560 3569 +9
==========================================
+ Hits 2703 2713 +10
Misses 636 636
+ Partials 221 220 -1
Continue to review full report at Codecov.
|
jmwilliams89
approved these changes
Jul 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
A common error is to use a regex pattern without any named capture groups. This errors out in that case because it's almost guaranteed to be unintended.
Sample error message:
{ "level": "error", "timestamp": "2020-07-09T10:10:32.855-0400", "message": "Failed to start carbon log agent", "error": { "description": "build pipeline: build plugins: no named capture groups in regex pattern", "suggestion": "use named capture groups like '^(?P<my_key>.*)$' to specify the key name for the parsed field", "details": { "plugin_id": "$.rp", "plugin_type": "regex_parser" } } }Please check that the PR fulfills these requirements